Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health HUD reskinning based on team #79

Merged
merged 4 commits into from Jun 2, 2019
Merged

Health HUD reskinning based on team #79

merged 4 commits into from Jun 2, 2019

Conversation

darshan3
Copy link
Member

Solves #73

How to test:

  1. Host a Light and Shadow game
  2. Join the game using one more client instance
  3. Choose one team with each of the players

Health HUD should be initially white dots and it should change to Spades for black team, hearts for red team.

Copy link
Contributor

@iaronaraujo iaronaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested this, and it is looking good! Well done! The only things I would like you to add to this PR are the classes' and public methods' JavaDoc

Copy link
Contributor

@iaronaraujo iaronaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes seem good! I am going to wait for someone else approval so we can merge it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants